Discussion:
[rancid] MAX_ROUNDS
Alan McKinnon
2013-06-28 08:02:47 UTC
Permalink
Is there a good reason why MAX_ROUNDS is limited to >= 1 in control_rancid?

I want it to be 0 and have good reasons for wanting that, are there any
side effects to this:

--- control_rancid 2012-03-20 20:36:41.000000000 +0200
+++ control_rancid.new 2013-06-28 10:03:32.000000000 +0200
@@ -128,11 +128,11 @@

# Number of things par should run in parallel.
PAR_COUNT=${PAR_COUNT:-5}
-# Number of times failed collections should be retried. Minimum 1.
+# Number of times failed collections should be retried. Minimum 0.
MAX_ROUNDS=${MAX_ROUNDS:-4}
-if [ $MAX_ROUNDS -lt 1 ] ; then
- echo "Error: MAX_ROUNDS must be at least 1."
- MAX_ROUNDS=1
+if [ $MAX_ROUNDS -lt 0 ] ; then
+ echo "Error: MAX_ROUNDS must be 0 or more."
+ MAX_ROUNDS=0
fi

# Bail if we do not have the necessary info to run
--
Alan McKinnon
***@gmail.com
heasley
2013-06-28 14:05:06 UTC
Permalink
Post by Alan McKinnon
Is there a good reason why MAX_ROUNDS is limited to >= 1 in control_rancid?
I want it to be 0 and have good reasons for wanting that, are there any
i think that change is fine.

Loading...